Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: add ru details in slow log and INFORMATION_SCHEMA.SLOW_QUERY (#49067) #50883

Closed
wants to merge 1 commit into from
Closed

executor: add ru details in slow log and INFORMATION_SCHEMA.SLOW_QUERY (#49067) #50883

wants to merge 1 commit into from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #49067

What problem does this PR solve?

Issue Number: close #42892 ref #49318

Problem Summary:

What changed and how does it work?

Add Resource_group, Request_unit_read, Request_unit_write and Time_queued_by_rc in slow_log and INFORMATION_SCHEMA.SLOW_QUERY.

NOTE: The three new fields are collected in client-go resourceControlInterceptor after tikv/client-go#1070

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. labels Feb 1, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 1, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.6 labels Feb 1, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 1, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 1, 2024
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-49067-to-release-7.6 branch from 6697282 to 8c51720 Compare February 1, 2024 06:28
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from glorv. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@glorv @ti-chi-bot
This is an automated cherry-pick of pingcap#49067
0c9581a 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-49067-to-release-7.6 branch from 8c51720 to 0c9581a Compare February 1, 2024 06:28
@nolouch nolouch closed this Feb 1, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 1, 2024

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build 0c9581a link true /test build
idc-jenkins-ci-tidb/check_dev_2 0c9581a link true /test check-dev2
idc-jenkins-ci-tidb/unit-test 0c9581a link true /test unit-test
idc-jenkins-ci-tidb/check_dev 0c9581a link true /test check-dev
idc-jenkins-ci-tidb/mysql-test 0c9581a link true /test mysql-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glorv glorv

Labels
do-not-merge/cherry-pick-not-approved ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @glorv @nolouch